Be clear about secretName restrictions #8782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔍 Preview links for changed docs |
🎉 Snyk checks have passed. No issues have been found so far.✅ security/snyk check is complete. No issues have been found. (View Details) ✅ license/snyk check is complete. No issues have been found. (View Details) |
barkbay
reviewed
Aug 4, 2025
pkg/apis/common/v1/common.go
Outdated
| @@ -115,7 +115,9 @@ type ObjectSelector struct { | |||
| ServiceName string `json:"serviceName,omitempty"` | |||
|
|
|||
| // SecretName is the name of an existing Kubernetes secret that contains connection information for associating an | |||
| // Elastic resource not managed by the operator. The referenced secret must contain the following: | |||
| // Elastic resource not managed by the operator. | |||
| // SecretName is only supported for monitoring associations. Refer to https://www.elastic.co/docs/deploy-manage/monitor/stack-monitoring/eck-stack-monitoring#k8s_connect_to_an_external_monitoring_elasticsearch_cluster | |||
There was a problem hiding this comment.
Isn't the link to the stack monitoring documentation a bit "restrictive"? We can use secretName to setup Fleet's Elasticsearch output for example. I was wondering if we should not document or validate any limitation on the parent attribute, for example on FleetServerRef.
There was a problem hiding this comment.
That's a good point. I think I overshot the target a bit after the issues our users had with this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be more explicit about the limitations of external associations. We have reports from users being confused about the availablity of the feature.