fix: cleanup orphaned secret mounts when removed from StackConfigPolicy #8937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes cleanup of orphaned secret mounts when removed from StackConfigPolicy. When a policy's
secretMountsconfiguration is updated to remove secret references,the copied secrets in the target Elasticsearch namespace are now automatically deleted.
Fixes #8921
Problem
When a StackConfigPolicy removes a secret reference from its
secretMountsconfiguration, the copied secret remains in the target Elasticsearch namespace indefinitely, leading to resource accumulation and potential confusion.Reproduction Steps (from issue #8921)
env: testsecretMountssecretMountssectionExpected Behavior
When a secret reference is removed from a StackConfigPolicy's
secretMounts, ECK should automatically delete the corresponding copied secret from the target namespace.Solution
Added
cleanupOrphanedSecretMounts()function that runs during policy reconciliation to:policy.k8s.elastic.co/source-secret-nameannotation (identifies SecretMount-managed secrets)secretMountslist in the policy spec