Skip to content
This repository was archived by the owner on Sep 17, 2024. It is now read-only.

fix: install mage on CI #1671

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

mdelapenya
Copy link
Contributor

What does this PR do?

It adds mage as a Go package to be used at CI time when building fleet-server's dependencies (using Beats build)

Why is it important?

The build for Fleet Server won't happen, as building metricbeat/heartbeat/filebeat won't be possible as the build tool is not installed at CI.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the Unit tests (make unit-test), and they are passing locally
  • I have run the End-2-End tests for the suite I'm working on, and they are passing locally
  • I have noticed new Go dependencies (run make notice in the proper directory)

Related issues

@mdelapenya mdelapenya self-assigned this Oct 18, 2021
@mdelapenya mdelapenya requested a review from a team October 18, 2021 14:04
@mdelapenya mdelapenya marked this pull request as ready for review October 18, 2021 14:06
Co-authored-by: Victor Martinez <[email protected]>
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 18, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-18T14:11:00.912+0000

  • Duration: 37 min 6 sec

  • Commit: 0d4626c

Test stats 🧪

Test Results
Failed 0
Passed 242
Skipped 0
Total 242

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@mdelapenya mdelapenya merged commit 45b88d2 into elastic:master Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants