Skip to content

Conversation

@belimawr
Copy link
Contributor

What does this PR do?

This PR adds a no-op logger

Why is it important?

We're moving away from using global logger instances, this is making more functions to require a logger as an argument, for testing having a no-op logger is very helpful

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

## Author's Checklist
## Related issues

@belimawr belimawr self-assigned this Jun 12, 2025
@belimawr belimawr requested a review from a team as a code owner June 12, 2025 13:11
@belimawr belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jun 12, 2025
@belimawr belimawr requested review from khushijain21 and leehinman and removed request for a team June 12, 2025 13:11
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @belimawr

@belimawr belimawr merged commit 4c5891c into elastic:main Jun 12, 2025
5 checks passed
@belimawr belimawr deleted the add-nop-logger branch June 12, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants