Skip to content

Disable stack traces for development/testing logger #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025
Merged

Disable stack traces for development/testing logger #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions logp/logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,18 @@ func NewProductionLogger(selector string, options ...LogOption) (*Logger, error)
// NewDevelopmentLogger returns a development suitable logp.Logger
func NewDevelopmentLogger(selector string, options ...LogOption) (*Logger, error) {
options = append([]LogOption{zap.AddCallerSkip(1)}, options...)
log, err := zap.NewDevelopment(options...)
log = log.Named(selector)
config := zap.NewDevelopmentConfig()
// if not disabled it shows stacktrace for warn, error level - which can be mistaken for a panic
config.DisableStacktrace = true
logger, err := config.Build(options...)
if err != nil {
return nil, err
}
return &Logger{log, log.Sugar()}, nil
logger = logger.Named(selector)
if err != nil {
return nil, err
}
return &Logger{logger, logger.Sugar()}, nil
}

// NewInMemory returns a new in-memory logger along with the buffer to which it
Expand Down
Loading