feat: add newzaplogger and rework logptest

[kruskall]

What does this PR do?

properly use zaptest logger instead of rewrapping the zap core

Why is it important?

this should make full use of zaptest logger and only log if a test fails

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have added tests that prove my fix is effective or that my feature works

Author's Checklist

• [ ]

Related issues

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 0a36c82

History

• 💚 Build #790 succeeded f4877ce
• 💔 Build #788 failed 9c1fa43
• 💚 Build #779 succeeded a272d15
• 💔 Build #777 failed c0abd1d
• 💔 Build #776 failed 5f5b8de

[belimawr]

LGTM

The only thing I'd add is to better document the modified/added functions to describe the behaviour of this log in a test scenario. Explaining if/when it will send logs to stdout/err, etc.

NewTestingLogger returns a testing suitable logp.Logger.

Does not explain what is the behaviour of 'suitable testing logger'.

[mauri870]

LGTM. The new constructor that also returns an observer is a very welcome addition!

[kruskall]

NewTestingLogger returns a testing suitable logp.Logger.

Does not explain what is the behaviour of 'suitable testing logger'.

I'm conflicted about this, it's an implementation but I have no strong opinion, happy to add it if there's consensus