Skip to content

Conversation

@kruskall
Copy link
Member

What does this PR do?

elastic forked the library to fix modern go version support and bump the x/crypto dependency

this has been fixed upstream so we should switch back to it

update imports and run go mod tidy

Why is it important?

the elastic fork of pkcs8 is only used in elastic-agent-libs

we should drop it and archive the repo

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

Related issues

elastic forker the library to fix modern go version support
and bump the x/crypto dependency

this has been fixed upstream so we should switch back to it

update imports and run go mod tidy
@kruskall kruskall requested a review from a team as a code owner August 20, 2025 04:12
@kruskall kruskall requested review from andrzej-stencel and khushijain21 and removed request for a team August 20, 2025 04:12
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@AndersonQ
Copy link
Member

I have a question. I'm seeing upstream still uses golang.org/x/crypto v0.22, whereas our forks uses v0.32.0. Here, golang.org/x/crypto is kept at a newer version due to another dependency. Are we fine with that? would github.com/youmark/pkcs8 be good even if we'd use golang.org/x/crypto v0.22?

Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. I can see a recent commit in elastic/pkcs8 fixing CVEs and that is not included in the upstream library. Is this accounted for?

EDIT: See Anderson's comment.

@kruskall
Copy link
Member Author

I have a question. I'm seeing upstream still uses golang.org/x/crypto v0.22, whereas our forks uses v0.32.0. Here, golang.org/x/crypto is kept at a newer version due to another dependency. Are we fine with that? would github.com/youmark/pkcs8 be good even if we'd use golang.org/x/crypto v0.22?

we can't use old x/crypto because other deps require a newer one.
That should be fine as it follows semver

Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I checked both repos and confirmed they are equivalent now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants