-
Notifications
You must be signed in to change notification settings - Fork 48
feat: switch back to upstream pkcs8 lib #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
elastic forker the library to fix modern go version support and bump the x/crypto dependency this has been fixed upstream so we should switch back to it update imports and run go mod tidy
💚 Build Succeeded
History
|
|
I have a question. I'm seeing upstream still uses golang.org/x/crypto v0.22, whereas our forks uses v0.32.0. Here, golang.org/x/crypto is kept at a newer version due to another dependency. Are we fine with that? would |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. I can see a recent commit in elastic/pkcs8 fixing CVEs and that is not included in the upstream library. Is this accounted for?
EDIT: See Anderson's comment.
we can't use old x/crypto because other deps require a newer one. |
mauri870
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I checked both repos and confirmed they are equivalent now.
What does this PR do?
elastic forked the library to fix modern go version support and bump the x/crypto dependency
this has been fixed upstream so we should switch back to it
update imports and run go mod tidy
Why is it important?
the elastic fork of pkcs8 is only used in elastic-agent-libs
we should drop it and archive the repo
Checklist
Author's Checklist
Related issues