"Replace global logger with local logger in tlscommon package" #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khushijain21
requested review from
andrzej-stencel and
leehinman
and removed request for
a team
khushijain21
changed the title
Collaborator
💚 Build Succeeded
History
|
kruskall
reviewed
Sep 5, 2025
| } | ||
|
|
||
| func NewClientWithDialer(d Dialer, c Config, network, host string, defaultPort int) (*Client, error) { | ||
| func NewClientWithDialer(d Dialer, c Config, network, host string, defaultPort int, logger *logp.Logger) (*Client, error) { |
Member
There was a problem hiding this comment.
this makes it a breaking change 😅
|
|
||
| func TLSDialer(forward Dialer, config *tlscommon.TLSConfig, timeout time.Duration) Dialer { | ||
| return TestTLSDialer(testing.NullDriver, forward, config, timeout) | ||
| func TLSDialer(forward Dialer, config *tlscommon.TLSConfig, timeout time.Duration, logger *logp.Logger) Dialer { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR supports additonal options on certain method in
tlscommonpackage to accept a local logger.This is part of the effort to get rid of global states.
Why is it important?
Checklist
Related issues