Export tlscommon.TLSCurveType #359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
requested review from
a team,
andrzej-stencel,
kaanyalti,
mauri870 and
swiatekm
and removed request for
a team
ycombinator
added
the
Team:Elastic-Agent-Control-Plane
swiatekm
previously approved these changes
Sep 26, 2025
swiatekm
left a comment
swiatekm
left a comment
There was a problem hiding this comment.
LGTM, but please fix the linter warnings.
Contributor
Author
Not sure how to fix the linter warnings since they all pertain to converting 64-bit integers into unsigned 8 or 16 bit integers. |
I'm assuming these are safe, and these numbers are really just small constants, in which case adding a gosec exception is fine. |
Collaborator
💚 Build Succeeded
History
|
AndersonQ
approved these changes
Sep 29, 2025
swiatekm
approved these changes
Sep 29, 2025
Contributor
Author
|
It doesn't look like we'll need this PR. Closing unmerged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR exports the
tlscommon.TLSCurveTypetype.Why is it important?
So other packages can import it, e.g. elastic/fleet-server#5562