Skip to content

Conversation

@AndersonQ
Copy link
Member

What does this PR do?

Adds an extra check to ensure DNSNames are non-empty

Why is it important?

Certificates DNS names should not be empty. Go introduced an extra check for that in 1.24.8 and later removed on 1.24.9 as it was a breaking change. As CreateCertificate allows for empty DNS names, let's avoid it on our side.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@AndersonQ AndersonQ requested a review from a team as a code owner October 15, 2025 07:06
@AndersonQ AndersonQ requested review from khushijain21 and rdner and removed request for a team October 15, 2025 07:06
@AndersonQ AndersonQ self-assigned this Oct 15, 2025
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 15, 2025
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @AndersonQ

@AndersonQ AndersonQ merged commit 85c4858 into elastic:main Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants