certutil: only add non-empty DNSNames to certificates #361
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds an extra check to ensure DNSNames are non-empty
Why is it important?
Certificates DNS names should not be empty. Go introduced an extra check for that in 1.24.8 and later removed on 1.24.9 as it was a breaking change. As
CreateCertificateallows for empty DNS names, let's avoid it on our side.Checklist
Related issues