[chore] Fix mage fmt and reformat code

api/npipe/listener_windows_test.go

@@ -24,9 +24,10 @@ import (
 	"net/http"
 	"testing"
 
-	"github.com/elastic/elastic-agent-libs/transport/httpcommon"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/elastic/elastic-agent-libs/transport/httpcommon"
 )
 
 func TestHTTPOverNamedPipe(t *testing.T) {

dev-tools/mage/benchmark.go

@@ -28,9 +28,10 @@ import (
 	"strconv"
 	"strings"
 
-	"github.com/elastic/elastic-agent-libs/dev-tools/mage/gotool"
 	"github.com/magefile/mage/mg"
 	"github.com/magefile/mage/sh"
+
+	"github.com/elastic/elastic-agent-libs/dev-tools/mage/gotool"
 )
 
 const (

dev-tools/mage/fmt.go

@@ -31,7 +31,7 @@ import (
 
 const (
 	// GoImportsImportPath controls the import path used to install goimports.
-	GoImportsImportPath = "golang.org/x/tools/cmd/goimports"
+	GoImportsImportPath = "golang.org/x/tools/cmd/goimports@latest"
 
 	// GoImportsLocalPrefix is a string prefix matching imports that should be
 	// grouped after third-party packages.

logp/configure/logging_test.go

@@ -20,9 +20,10 @@ package configure
 import (
 	"testing"
 
+	"github.com/stretchr/testify/require"
+
 	"github.com/elastic/elastic-agent-libs/config"
 	"github.com/elastic/elastic-agent-libs/logp"
-	"github.com/stretchr/testify/require"
 )
 
 func TestLoggerOutputEnvironment(t *testing.T) {

logp/logptest/logptest.go

@@ -20,11 +20,12 @@ package logptest
 import (
 	"testing"
 
-	"github.com/elastic/elastic-agent-libs/logp"
 	"go.uber.org/zap"
 	"go.uber.org/zap/zapcore"
 	"go.uber.org/zap/zaptest"
 	"go.uber.org/zap/zaptest/observer"
+
+	"github.com/elastic/elastic-agent-libs/logp"
 )
 
 // NewTestingLogger returns a testing suitable logp.Logger.

monitoring/metrics_test.go

@@ -144,7 +144,7 @@ func TestSafeVars(t *testing.T) {
 			})
 			wg.Wait()
 		})
-		
+
 		t.Run("NewTimestamp", func(t *testing.T) {
 			reg := NewRegistry()
 			name := "foo"

periodic/ratelimited_test.go

@@ -27,9 +27,10 @@ import (
 	"testing"
 	"time"
 
-	"github.com/elastic/elastic-agent-libs/iobuf"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/elastic/elastic-agent-libs/iobuf"
 )
 
 type syncBuffer struct {

processors/dissect/delimiter.go

@@ -22,7 +22,7 @@ import (
 	"strings"
 )
 
-//delimiter represents a text section after or before a key, it keeps track of the needle and allows
+// delimiter represents a text section after or before a key, it keeps track of the needle and allows
 // to retrieve the position where it starts from a haystack.
 type delimiter interface {
 	// IndexOf receives the haystack and a offset position and will return the absolute position where

processors/dissect/field.go

@@ -114,6 +114,7 @@ func (f baseField) String() string {
 // dissect: %{key}
 // message: hello
 // result:
+//
 //	key: hello
 type normalField struct {
 	baseField
@@ -129,6 +130,7 @@ func (f normalField) Apply(b string, m Map) {
 // dissect: %{} %{key}
 // message: hello world
 // result:
+//
 //	key: world
 type skipField struct {
 	baseField
@@ -147,6 +149,7 @@ func (f skipField) IsSaveable() bool {
 // dissect: %{?key} %{&key}
 // message: hello world
 // result:
+//
 //	hello: world
 //
 // Deprecated: see pointerField
@@ -182,6 +185,7 @@ func (f pointerField) IsSaveable() bool {
 // dissect: %{?key} %{&key}
 // message: hello world
 // result:
+//
 //	hello: world
 type indirectField struct {
 	baseField
@@ -201,11 +205,13 @@ func (f indirectField) Apply(b string, m Map) {
 // dissect: %{+key} %{+key}
 // message: hello world
 // result:
+//
 //	key: hello world
 //
 // dissect: %{+key/2} %{+key/1}
 // message: hello world
 // result:
+//
 //	key: world hello
 type appendField struct {
 	baseField

safemapstr/safemapstr.go

@@ -28,10 +28,10 @@ const alternativeKey = "value"
 // Put This method implements a way to put dotted keys into a M while
 // ensuring they don't override each other. For example:
 //
-//  a := M{}
-//  safemapstr.Put(a, "com.docker.swarm.task", "x")
-//  safemapstr.Put(a, "com.docker.swarm.task.id", 1)
-//  safemapstr.Put(a, "com.docker.swarm.task.name", "foobar")
+//	a := M{}
+//	safemapstr.Put(a, "com.docker.swarm.task", "x")
+//	safemapstr.Put(a, "com.docker.swarm.task.id", 1)
+//	safemapstr.Put(a, "com.docker.swarm.task.name", "foobar")
 //
 // Will result in `{"com":{"docker":{"swarm":{"task":{"id":1,"name":"foobar","value":"x"}}}}}`
 //

transform/typeconv/typeconv.go

@@ -118,11 +118,12 @@
 // Go structures can influence the transformation via tags using the `struct` namespace.
 // If the tag is missing, the structs field names are used. Additional options are separates by `,`.
 // options:
-//   `squash`, `inline`: The fields in the child struct/map are assumed to be inlined, without reporting a sub-oject.
-//   `omitempty`: The field is not converted if it is "empty". For example an
-//                empty string, array or `nil` pointers are assumed to be empty. In either case the original value
-//                in `to` will not be overwritten.
-//   `omit`, `-`: Do not convert the field.
+//
+//	`squash`, `inline`: The fields in the child struct/map are assumed to be inlined, without reporting a sub-oject.
+//	`omitempty`: The field is not converted if it is "empty". For example an
+//	             empty string, array or `nil` pointers are assumed to be empty. In either case the original value
+//	             in `to` will not be overwritten.
+//	`omit`, `-`: Do not convert the field.
 func Convert(to, from interface{}) (err error) {
 	c, _ := convPool.Get().(*Converter)
 	defer convPool.Put(c)
@@ -177,7 +178,7 @@
 }
 
 func (u *timeUnfolder) OnInt(ctx gotype.UnfoldCtx, in int64) error {
 	return u.OnUint(ctx, uint64(in))
 }
 func (u *timeUnfolder) OnFloat(ctx gotype.UnfoldCtx, f float64) error {
 	return u.OnUint(ctx, uint64(f))
@@ -230,13 +231,13 @@
 		if offset < -32768 || offset == -1 || offset > 32767 {
 			offset = 0 // Note: best effort. Ignore offset if it becomes an unexpected value
 		}
 		off = int16(offset)
 	}
 
 	sec := uint64(ts.Unix())
 	extra := (uint64(encodingVersion) << 56) |
 		(uint64(uint16(off)) << 32) |
 		uint64(ts.Nanosecond())
 
 	return extra, sec
 }
@@ -249,9 +250,9 @@
 		return ts, fmt.Errorf("invalid timestamp [%x, %x]", extra, sec)
 	}
 
 	nsec := uint32(extra)
 	off := int16(extra >> 32)
 	ts = time.Unix(int64(sec), int64(nsec))
 
 	// adjust location by offset. time.Unix creates a timestamp in the local zone
 	// by default. Only change this if off does not match the local zone it's offset.
@@ -259,7 +260,7 @@
 		ts = ts.UTC()
 	} else if off != 0 {
 		_, locOff := ts.Zone()
 		if off != int16(locOff/60) {
 			ts = ts.In(time.FixedZone("", int(off*60)))
 		}
 	}

transport/httpcommon/diag_test.go

@@ -34,8 +34,9 @@ import (
 	"testing"
 	"time"
 
-	"github.com/elastic/elastic-agent-libs/transport/tlscommon"
 	"github.com/stretchr/testify/require"
+
+	"github.com/elastic/elastic-agent-libs/transport/tlscommon"
 )
 
 var ser int64 = 1

transport/tlscommon/tls_fips_test.go

@@ -26,9 +26,10 @@ import (
 	"path/filepath"
 	"testing"
 
-	"github.com/elastic/elastic-agent-libs/logp/logptest"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/elastic/elastic-agent-libs/logp/logptest"
 )
 
 // TestFIPSCertifacteAndKeys tests that encrypted private keys fail in FIPS mode

transport/tlscommon/tls_nofips_test.go

@@ -26,9 +26,10 @@ import (
 	"path/filepath"
 	"testing"
 
-	"github.com/elastic/elastic-agent-libs/logp/logptest"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
+
+	"github.com/elastic/elastic-agent-libs/logp/logptest"
 )
 
 // TestNoFIPSCertificateAndKeys tests that encrypted private keys are supported in none FIPS mode