Skip to content

Add kibana func to update download source by id #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 2, 2025
Merged

Add kibana func to update download source by id #371

merged 4 commits into from
Dec 2, 2025
+108 −0

Conversation

@michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Dec 2, 2025 •
edited
Loading

What does this PR do?

Add a call to the Kibana client to update a download source by ID.
See: https://www.elastic.co/docs/api/doc/kibana/operation/operation-put-fleet-agent-download-sources-sourceid

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works

Related issues

@michel-laterman michel-laterman requested a review from a team as a code owner December 2, 2025 00:21
@michel-laterman michel-laterman added enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Dec 2, 2025
@michel-laterman michel-laterman requested review from faec and leehinman and removed request for a team December 2, 2025 00:21
leehinman
leehinman reviewed Dec 2, 2025
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, should probably have a test in fleet_test.go though.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Dec 2, 2025
@michel-laterman
Copy link
Contributor Author

michel-laterman commented Dec 2, 2025

Build is failing due to gvm version, issue is addressed here: #372

@elasticmachine
Copy link
Collaborator

elasticmachine commented Dec 2, 2025

💚 Build Succeeded

History

leehinman
leehinman approved these changes Dec 2, 2025
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michel-laterman michel-laterman merged commit a0201d3 into elastic:main Dec 2, 2025
5 checks passed
@michel-laterman michel-laterman deleted the enhance/add-fleet-update-download-sources branch December 2, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leehinman leehinman leehinman approved these changes

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

No one assigned

Labels

enhancement New feature or request Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michel-laterman @elasticmachine @leehinman @pierrehilbert