Skip to content

Conversation

@kruskall
Copy link
Member

@kruskall kruskall commented Aug 6, 2025

What does this PR do?

drop remaining usage of global logging funcs

Why is it important?

last remaining change to remove logp.{Info, Err, Warn, etc.} funcs

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • [ ]

Related issues

drop remaining usage of global logging funcs
@kruskall kruskall requested a review from a team as a code owner August 6, 2025 00:15
@kruskall kruskall requested review from AndersonQ and rdner and removed request for a team August 6, 2025 00:15
@kruskall kruskall requested a review from khushijain21 August 6, 2025 12:19
Copy link
Contributor

@khushijain21 khushijain21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logger changes look good

@kruskall kruskall merged commit 0ba9901 into elastic:main Aug 7, 2025
5 checks passed
@kruskall kruskall deleted the feat/drop-logp-levels branch August 7, 2025 06:29
@khushijain21
Copy link
Contributor

Hello @kruskall , any reason we made logger changes to only windows build of diskstat here https://github.com/elastic/elastic-agent-system-metrics/pull/254/files#diff-c328376cb90ea4eaf80769a9e40f7902cf81efbfc559ff18ecd39aa02d50313eR52-R53

Beats is failing because the API change is not consistent for all OS types

@kruskall
Copy link
Member Author

mmh, that looks like a bug

@khushijain21
Copy link
Contributor

Fixing it in #259

@khushijain21 khushijain21 mentioned this pull request Aug 21, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants