-
Notifications
You must be signed in to change notification settings - Fork 27
feat: replace global logging func with local logger #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
drop remaining usage of global logging funcs
Co-authored-by: Khushi Jain <[email protected]>
khushijain21
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logger changes look good
|
Hello @kruskall , any reason we made logger changes to only windows build of Beats is failing because the API change is not consistent for all OS types |
|
mmh, that looks like a bug |
|
Fixing it in #259 |
What does this PR do?
drop remaining usage of global logging funcs
Why is it important?
last remaining change to remove logp.{Info, Err, Warn, etc.} funcs
Checklist
CHANGELOG.mdAuthor's Checklist
Related issues