Remove config parsing from monitoring manager #11466
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # internal/pkg/agent/application/monitoring/component/v1_monitor.go # internal/pkg/agent/application/monitoring/component/v1_monitor_test.go
swiatekm
added
Cleanup
skip-changelog
backport-active-all
swiatekm
added
backport-8.19
swiatekm
added
the
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Contributor
|
Did you mean to check in the |
ycombinator
reviewed
Dec 1, 2025
ycombinator
reviewed
Dec 1, 2025
ycombinator
requested changes
Dec 1, 2025
Contributor
There was a problem hiding this comment.
Cleanup LGTM. Left a couple of nitpicks and a question about committing the testsignal binary.
Co-authored-by: Shaunak Kashyap <[email protected]>
Contributor
Author
It's already there. I think it got into this commit during a complicated rebase, I removed it. |
ycombinator
approved these changes
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Drops the policy parsing code from the monitoring manager. This configuration is reloaded via the
Reloadfunction and the manager has access to it in a structured format.Why is it important?
The parsing code is ugly, difficult to understand, and unnecessary.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testHow to test this PR locally
Build agent locally, start it, and try changing the monitoring settings. In particular, this PR affects the
failure_thresholdandmetrics_periodsettings.