Skip to content

Conversation

@rogercoll
Copy link
Contributor

What does this PR do?

Fixes the caputred group of the updatecli regex

Why is it important?

Fixes the execution, see sample action output:

condition: condition#is-new-version
------------------------
The shell 🐚 command "/bin/sh /tmp/updatecli/bin/b997ea153e9bfe0589efdab5d77ff5403bb61967c423e2b536950c893b408151.sh" exited on error (exit code 2) with the following output:
----
----

command stderr output was:
----
/tmp/updatecli/bin/b997ea153e9bfe0589efdab5d77ff5403bb61967c423e2b536950c893b408151.sh: 1: [: 0.11.1: unexpected operator

----
shell command failed. Expected exit code 0 but got 2
✗ shell condition of type "console/output" not passing

Example execution: #11541

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@rogercoll rogercoll requested review from a team as code owners December 2, 2025 17:57
@rogercoll rogercoll added skip-changelog backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches labels Dec 2, 2025
swiatekm
swiatekm previously approved these changes Dec 2, 2025
v1v
v1v previously approved these changes Dec 2, 2025
@rogercoll rogercoll dismissed stale reviews from v1v and swiatekm via 38bf786 December 2, 2025 19:13
v1v
v1v previously approved these changes Dec 2, 2025
@rogercoll
Copy link
Contributor Author

@v1v @swiatekm Apologies for the missed review, just applied suggestions from #11542 (comment)

@pierrehilbert pierrehilbert requested review from swiatekm and v1v December 3, 2025 07:40
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Dec 3, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants