-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE - wait 8.16 release][8.16](backport #5878) [Flaky Test] Fix TestHTTPSProxy #5901
base: 8.16
Are you sure you want to change the base?
Conversation
Cherry-pick of 02fb75e has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
(cherry picked from commit 02fb75e) # Conflicts: # testing/proxytest/proxytest_test.go
5e388c4
to
257c8be
Compare
Quality Gate passedIssues Measures |
This pull request has not been merged yet. Could you please review and merge it @AndersonQ? 🙏 |
needs #5928 to be merged first
What does this PR do?
It moves the close of the proxy and target http server to
t.Cleanup()
Why is it important?
Just using
defer
was causing the last request log to be logged after the test had ended, what lead to a panic.Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragments
using the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
How to test this PR locally
On a Mac (the panics happened on Mac)
It should succeed
Related issues
Questions to ask yourself
This is an automatic backport of pull request #5878 done by [Mergify](https://mergify.com).