-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Buildkite integration tests: Run integration tests on ARM #5956
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @pazone? 🙏
|
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Where do we run the non-sudo tests? |
I can add return non-sudo tests back to the pipeline. I'd do that in a separate PR |
artifact_paths: | ||
- build/** | ||
agents: | ||
provider: "gcp" | ||
imageProject: elastic-images-qa | ||
machineType: "n1-standard-8" | ||
image: "family/platform-ingest-elastic-agent-ubuntu-2204" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like agent tests are currently running against 2404, not 2204
@@ -38,115 +38,45 @@ steps: | |||
- package-it | |||
- integration-ess | |||
steps: | |||
- label: "Default" | |||
key: stateful-ubuntu-default-sudo | |||
- label: "x86:Group: {{matrix}}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: more accurate to call this x64
? Or x86-x64
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
x86_64. But now i think amd64
is more clear 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go with x86_64, since I think we use that term more consistently in other places
Do you want to enable with this PR or a follow-up? |
What does this PR do?
Enhances the buildkite tests pipeline by ARM tests. It uses the prebuilt Ubuntu 22.04 ARM image
Runs integration test groups separately. Allows independent reruns.
Tested here: Example build.
Note: It doesn't replace current integration tests. The new buildkite pipeline is not triggered by GitHub events
Why is it important?
We have to test elastic agent on ARM architecture
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself