feat(settings): expose global charts context for settings #1424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
adds
ElasticChartsProvider
to passEchContext
value to set globally shared values across all chart instances. This remediates the need to provide atheme
andbaseTheme
to all chart instances, thetheme
will just be merged with any provided usertheme
, when the chart is wrapped in the provider.used as...
Details
Leaving the api for
EchContext
open for future props beyond justsettings
.Issues
This completes a long ignored usage for shared global settings
fix #718
Depends on #1421
Checklist
:xy
,:partition
):interactions
,:axis
):theme
label has been added and the@elastic/eui-design
team has been pinged when there areTheme
API changescloses #123
,fixes #123
)packages/charts/src/index.ts
dark
,light
,eui-dark
&eui-light