Hacking new serialization with Steve at techorama #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `ConsumeOutboundEventsAsync` in `BufferedChannelBase.cs` to conditionally cancel `_exitCancelSource` using `CancelAsync` for .NET 8.0 or greater, and `Cancel` for other versions. Modified `ToString` method to return a nullable string (`string?`). Updated target frameworks in `Elastic.Channels.csproj` and `Elastic.Ingest.Elasticsearch.csproj` to include `net8.0`. Enhanced `WriteBufferToStreamAsync` in `ElasticsearchChannelBase.Bytes.cs` to handle `IndexOp.CreateNoParams` and use `SerializePlainIndexHeaderAsync` for serialization. Removed several `using` directives in `ElasticsearchChannelBase.Serialization.cs` and introduced static read-only spans for `PlainIndexBytesSpan` and `PlainCreateBytesSpan`. Added conditional compilation for serialization methods to use `ValueTask` and `ReadOnlySpan<byte>` for .NET 8.0 or greater, and `byte[]` for other versions.
- DataStreamChannel.cs: Removed unnecessary BulkHeader creation. - Elastic.Ingest.Elasticsearch.csproj: Enabled unsafe blocks. - ElasticsearchChannelBase.Bytes.cs: Standardized IReadOnlyList<TEvent> handling and updated SerializeHeaderAsync. - ElasticsearchChannelBase.Serialization.cs: Added usings, optimized serialization for .NET 8.0, and added new methods. - BulkHeader.cs: Standardized comment punctuation. - Elastic.Ingest.Elasticsearch.Tests.csproj: Added net8.0 target framework. - IndexChannelTests.cs: Added new tests and enhanced ExecuteAndAssert method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.