Skip to content

Show errors if any when updating managed setting in saved object #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Show errors if any when updating managed setting in saved object #3057

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5193d5
Show errors if any when updating managed setting in saved object
mrodm Nov 6, 2025
22575c2
Re-phrase error message
mrodm Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions internal/kibana/savedobjects.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,13 @@ func (c *Client) SetManagedSavedObject(ctx context.Context, savedObjectType stri

// Even if no error is returned, we need to check if the import was successful.
if !resp.Success {
if len(resp.Errors) > 0 {
var errorMessages []string
for _, importError := range resp.Errors {
errorMessages = append(errorMessages, fmt.Sprintf("ID: %s, Type: %s, Error: %v", importError.ID, importError.Type, importError.Error))
}
return fmt.Errorf("importing %s %s was not successful: %s", savedObjectType, id, strings.Join(errorMessages, "; "))
}
return fmt.Errorf("importing %s %s was not successful", savedObjectType, id)
}

Expand Down