Enhance StreamResponse handling and update dependencies #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevejgordon
force-pushed
the
bug/fix-stream-response
branch
from
eab800f to
2300050
Compare
Mpdreamz
requested changes
Oct 22, 2024
flobernd
reviewed
Oct 29, 2024
src/Elastic.Transport/Components/TransportClient/HttpRequestInvoker.cs
Outdated
Show resolved
Hide resolved
src/Elastic.Transport/Components/Pipeline/DefaultResponseBuilder.cs
Outdated
Show resolved
Hide resolved
Mpdreamz
reviewed
Oct 29, 2024
src/Elastic.Transport/Components/Pipeline/DefaultResponseBuilder.cs
Outdated
Show resolved
Hide resolved
Mpdreamz
reviewed
Oct 29, 2024
Collaborator
Author
|
Notes from latest changes: We have now unsealed StreamResponse to allow for derived responses that rely on the stream (such as the potential specialised bulk response for the ingest work. While testing, I noticed that with |
Member
|
Sorry about the conflict! |
flobernd
approved these changes
Oct 30, 2024
Updated `ResponseBuilderDefaults` to include `StreamResponse` in `SpecialTypes`. Refactored `SetBodyCoreAsync` in `DefaultResponseBuilder.cs` for readability and removed unnecessary `using` statements. Modified `RequestCoreAsync` in `HttpWebRequestInvoker.cs` and `BuildResponseAsync` in `InMemoryRequestInvoker.cs` to handle `StreamResponse` types with proper disposal. Updated `Elastic.Transport.csproj` to reference `System.Text.Json` version `8.0.5`.
Renamed variable from `receive` to `receivedResponse` in `RequestCoreAsync` method across `HttpRequestInvoker.cs` and `HttpWebRequestInvoker.cs` for better clarity. Updated `using` statements accordingly. Added `try-catch` blocks around response handling logic to ensure `receivedResponse` is disposed of properly, preventing resource leaks. Adjusted finalizer in `StreamResponse` to use `receivedResponse.Dispose()`. Properly indented OpenTelemetry attributes setting logic within the `try` block.
Add `LeaveOpen` property to `StreamResponse` and `TransportResponse` classes for flexible stream management.
stevejgordon
force-pushed
the
bug/fix-stream-response
branch
from
d1c4f20 to
20bcdf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
ResponseBuilderDefaultsto includeStreamResponseinSpecialTypes. RefactoredSetBodyCoreAsyncinDefaultResponseBuilder.csfor readability and removed unnecessaryusingstatements. ModifiedRequestCoreAsyncinHttpWebRequestInvoker.csandBuildResponseAsyncinInMemoryRequestInvoker.csto handleStreamResponsetypes with proper disposal. UpdatedElastic.Transport.csprojto referenceSystem.Text.Jsonversion8.0.5.