Add copy constructor to RequestConfiguration{Descriptor}

[flobernd]

As titled.

What is the deal with DisablePing, EnableHttpPipelining in RequestConfiguration (both properties are not part of the interface) and _enableHttpCompression and _maxRetryTimeout in RequestConfigurationDescriptor (both fields don't have a corresponding setter-method)?

Is that by design or a leftover of the refactoring?

[stevejgordon]

As titled.

What is the deal with DisablePing, EnableHttpPipelining in RequestConfiguration (both properties are not part of the interface) and _enableHttpCompression and _maxRetryTimeout in RequestConfigurationDescriptor (both fields don't have a corresponding setter-method)?

Is that by design or a leftover of the refactoring?

I think some of those need cleaning/fixing up. DisablePing, I think, was renamed to DisablePings and EnabledHttpPipelining to HttpPipeliningEnabled. My guess is _enableHttpCompression and _maxRetryTimeout should have setter methods.

[Mpdreamz]

Echo'ing what Steve said, the RequestCongfiguration and RequestData need another pass to ensure conformity.

Happy to take that on in another PR :)

For this PR can we add another test to ensure all properties get passed through similar to ITransportConfiguration ?

elastic-transport-net/tests/Elastic.Transport.Tests/Configuration/TransportConfigurationTests.cs

Line 42 in 95ea6c6

public void CopiesAllProperties()

[flobernd]

That property was not wired at all 😅

[flobernd]

I removed the properties which are not present in the interface, added methods for the ones that ARE present in the interface but were not settable in the descriptor, and added some tests for the RequestConfiguration{Descriptor}.

[stevejgordon]

LGTM - thanks