Add support for response builders on IRequestConfiguration #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows consumers to provide builders on a per-request basis, required in ingest for streaming bulk response. Fixes potential null ref exceptions when disposing streams. This also pins the SDK to 8.x until we're ready for 9.x
Mpdreamz
approved these changes
Nov 14, 2024
Member
Mpdreamz
left a comment
Mpdreamz
left a comment
There was a problem hiding this comment.
LGTM,
One downside is that this will create a new RequestData each time because local is not null. Although I don't have a solution for this.
Can the per request also utilize a request specific response type so that it can inject a global builders collection where CanBuild() does the type check for the request specific response type?
e.g class StreamBulkResponse : BulkResponse {}
Either way this is good additional functionality.
Collaborator
Author
|
Yeah, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows consumers to provide builders on a per-request basis, which is required in ingest for streaming bulk response.
IRequestConfigurationandRequestConfigurationDescriptorinto their own files.