Skip to content

Improve UrlFormatter #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2024
Merged

Improve UrlFormatter #135

merged 1 commit into from
Nov 19, 2024

Conversation

@flobernd
Copy link
Member

@flobernd flobernd commented Nov 14, 2024

I noticed that UrlFormatter.CreateString() does not prefer custom IUrlParameter.GetString() implementations when a type as well implements IList/IEnumerable.

Besides that, the PR contains the following additional improvements:

  • Recursively call CreateString() for collection items
  • Remove duplicate enum member handling
  • Makes sure that CreateString() never returns null (there is no value in distinguishing between null and string.Empty here)

Mpdreamz
Mpdreamz approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@flobernd flobernd added enhancement New feature or request v0.5.3 labels Nov 19, 2024
@flobernd flobernd merged commit 4557279 into main Nov 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mpdreamz Mpdreamz Mpdreamz approved these changes

@stevejgordon stevejgordon Awaiting requested review from stevejgordon

Assignees

No one assigned

Labels

enhancement New feature or request v0.5.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@flobernd @Mpdreamz