Add AOT support to Elastic.Transport. #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Promote ApiKey as default implementation (also documentated default as part of client bootstrapping instruction on serverless). Make it easier to bootstrap a transport/cloudnodepool using a cloud endpoint an authentication method. No need to externally construct a cloud id.
flobernd
reviewed
May 20, 2025
| <IsAotCompatible>true</IsAotCompatible> | ||
| <JsonSerializerIsReflectionEnabledByDefault>false</JsonSerializerIsReflectionEnabledByDefault> | ||
| </PropertyGroup> | ||
| <PropertyGroup Condition="'$(TargetFramework)' == 'net8.0'"> |
Member
There was a problem hiding this comment.
@Mpdreamz I learned that it's better to use e.g. $([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net8.0')) in these cases, because otherwise, the condition does not equate to true for "sub-frameworks" like net8.0-ios, etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promote ApiKey as default implementation (also documentated default as part of client bootstrapping instruction on serverless).
Make it easier to bootstrap a transport/cloudnodepool using a cloud endpoint an authentication method. No need to externally construct a cloud id.