Skip to content

Address new AOT warnings in dotnet 9 #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2025
Merged

Address new AOT warnings in dotnet 9 #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Elastic.Transport/Responses/Dynamic/DynamicDictionary.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ namespace Elastic.Transport;
/// <summary>
/// A dictionary that supports dynamic access.
/// </summary>
[UnconditionalSuppressMessage("AotAnalysis", "IL3050:RequiresDynamicCode", Justification = "Manually verified")]
public sealed class DynamicDictionary
: DynamicObject,
IEquatable<DynamicDictionary>,
Expand Down
4 changes: 2 additions & 2 deletions src/Elastic.Transport/Responses/Dynamic/DynamicValue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
using System.Globalization;
using System.Linq;
using System.Linq.Expressions;
using System.Runtime.CompilerServices;
using System.Text.Json;
//using Microsoft.CSharp.RuntimeBinder;
using Elastic.Transport.Extensions;
Expand All @@ -30,7 +29,7 @@ namespace Elastic.Transport;
///
/// <para>This is `dynamic` through <see cref="DynamicObject"/> and supports direct casting various valuetypes</para>
/// <para>Since `dynamic` can be scary in .NET this response also exposes a safe traversal mechanism under
/// <see cref="Get{T}"/> which support an xpath'esque syntax to fish for values in the returned json.
/// <see cref="Get{T}"/> which support a xpath'esque syntax to fish for values in the returned json.
/// </para>
/// </summary>
public sealed class DynamicValue : DynamicObject, IEquatable<DynamicValue>, IConvertible, IReadOnlyCollection<DynamicValue>
Expand All @@ -41,6 +40,7 @@ public sealed class DynamicValue : DynamicObject, IEquatable<DynamicValue>, ICon
/// Initializes a new instance of the <see cref="DynamicValue" /> class.
/// </summary>
/// <param name="value">The value to store in the instance</param>
[UnconditionalSuppressMessage("AotAnalysis", "IL3050:RequiresDynamicCode", Justification = "Manually verified")]
public DynamicValue(object value) => _value = value is DynamicValue av ? av.Value : value;

/// <summary>
Expand Down
Loading