Migrate integration tests to built JS files #2750
Open
+630
−1,750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The integration test suite was previously generating and running unit tests in memory, which proves to be a complicated solution. This removes that test runner and replaces it with a test builder that generates JS files full of
tap-compatible unit tests, and then runs them.It also switches from using the
yaml-rest-testsdirectory of the Elasticsearch repo to using the elasticsearch-clients-tests repo, which uses the same YAML format but the test suite is better optimized for testing client against language clients.Many tests are skipped here, but notes are included as to why. This should run nearly 700 assertions successfully in approximately 3.5 minutes.
Hopefully will allow us to close #2750.