Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update search application APIs from experimental to beta #2208

Merged
merged 7 commits into from
Jul 27, 2023
Merged

Update search application APIs from experimental to beta #2208

merged 7 commits into from
Jul 27, 2023

Conversation

kderusso
Copy link
Member

@kderusso kderusso commented Jul 25, 2023 •
edited
Loading

Updates search applications APIs to beta.

@kderusso kderusso requested review from ioanatia and a team July 25, 2023 14:28
@kderusso kderusso marked this pull request as ready for review July 25, 2023 14:29
JoshMock
JoshMock requested changes Jul 25, 2023
View reviewed changes
Copy link
Member

@JoshMock JoshMock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the correct order of operations for making these spec changes would be to update the relevant files in the /specification directory, at which point CI will generate an updated schema.json file and commit it for you.

@kderusso
Copy link
Member Author

🤦‍♀️ Thanks @JoshMock, fixed!

@kderusso kderusso requested a review from JoshMock July 25, 2023 18:29
@kderusso kderusso changed the title Update search application APIs from experimental to stable Update search application APIs from experimental to beta Jul 26, 2023
@github-actions
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
search_application.delete ⚪ Missing test Missing test
search_application.get ⚪ Missing test Missing test
search_application.list ⚪ Missing test Missing test
search_application.put ⚪ Missing test Missing test
search_application.search ⚪ Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@kderusso kderusso merged commit 66771b5 into main Jul 27, 2023
5 checks passed
@kderusso kderusso deleted the kderusso/update-search-applications-apis branch July 27, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioanatia ioanatia ioanatia approved these changes

@JoshMock JoshMock JoshMock approved these changes

Assignees
No one assigned
Labels
specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kderusso @JoshMock @ioanatia