-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Adds descriptions for Enrich APIs #2215
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Left a few non-blocking comments.
/** | ||
* Objects containing information about each coordinating ingest node for | ||
* configured enrich processors. | ||
*/ | ||
coordinator_stats: CoordinatorStats[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that's on your radar already, but we shouldn't forget to add descriptions for ExecutingPolicy
and CoordinatorStats
too (here).
specification/enrich/execute_policy/ExecuteEnrichPolicyRequest.ts
Outdated
Show resolved
Hide resolved
@abdonpijpelink Thanks for your review. I addressed your comments via b2361b7. |
Following you can find the validation results for the APIs you have changed.
You can validate these APIs yourself by using the |
Overview
Related to #964.
Adds descriptions to Enrich API properties. Source of info: https://www.elastic.co/guide/en/elasticsearch/reference/master/enrich-apis.html