Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add descriptions for remaining aggs #2237

Merged
merged 7 commits into from
Aug 15, 2023
Merged

[DOCS] Add descriptions for remaining aggs #2237

merged 7 commits into from
Aug 15, 2023

Conversation

abdonpijpelink
Copy link
Contributor

Relates to #964. Follow up of #2225.

Adds descriptions for the remaining aggregations. Descriptions were sourced from https://www.elastic.co/guide/en/elasticsearch/reference/master/search-aggregations.html and subpages.

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left a couple of tiny comments.

specification/_types/aggregations/AggregationContainer.ts Outdated Show resolved Hide resolved
specification/_types/aggregations/bucket.ts Outdated Show resolved Hide resolved
specification/_types/aggregations/bucket.ts Outdated Show resolved Hide resolved
@abdonpijpelink abdonpijpelink merged commit 82344fa into main Aug 15, 2023
4 checks passed
@abdonpijpelink abdonpijpelink deleted the more-aggs branch August 15, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants