Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds description to global APIs part 2 #2270

Merged
merged 3 commits into from
Sep 6, 2023
Merged

Conversation

szabosteve
Copy link
Contributor

Overview

Related to #964.

Adds descriptions to the:

  • create
  • delete
  • delete by query
  • delete by query rethrottle
  • delete script
  • get script
  • open PIT
  • PUT script
  • scripts painless execute
  • update by query
  • update by query rethrottle
    APIs.

Source of info:

Copy link
Contributor

@abdonpijpelink abdonpijpelink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I've left a couple of suggestions. Feel free to ignore.

@szabosteve szabosteve enabled auto-merge (squash) September 6, 2023 15:49
@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Following you can find the validation results for the APIs you have changed.

API Status Request Response
create 🟢 24/24 23/23
delete_by_query_rethrottle 🟢 1/1 1/1
delete_by_query 🟢 5/5 4/4
delete_script 🟢 8/8 8/8
delete 🟢 34/34 34/34
get_script 🟢 12/12 12/12
open_point_in_time 🟢 10/10 10/10
put_script 🟢 9/9 9/9
scripts_painless_execute 🟢 2/2 2/2
update_by_query_rethrottle 🟢 1/1 1/1
update_by_query 🟢 5/5 4/4

You can validate these APIs yourself by using the make validate target.

@szabosteve szabosteve merged commit ad975f6 into main Sep 6, 2023
5 checks passed
@szabosteve szabosteve deleted the szabosteve/global-2 branch September 6, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants