Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IP Location APIs #3107

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add IP Location APIs #3107

wants to merge 1 commit into from
+1,057 −0

Conversation

pquentin
Copy link
Member

@pquentin pquentin commented Nov 8, 2024

I extracted the rest-api-spec JSON files from #3019. We'll need a review from the Data Management team before merging.

@pquentin pquentin requested a review from a team as a code owner November 8, 2024 09:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Following you can find the validation results for the APIs you have changed.

API Status Request Response
ingest.delete_ip_location_database ⚪ Missing test Missing test
ingest.get_ip_location_database ⚪ Missing test Missing test
ingest.put_ip_location_database 🟠 Missing recording Missing recording

You can validate these APIs yourself by using the make validate target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joegallo joegallo Awaiting requested review from joegallo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport 8.x backport 8.16 specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pquentin