Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0] Add Google Vertex AI inference details (#4028) #4089

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Mar 25, 2025

Backport

This will backport the following commits from main to 9.0:

Questions ?

Please refer to the Backport tool documentation

@lcawl lcawl requested a review from a team as a code owner March 25, 2025 15:18
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.put_googlevertexai Missing test Missing test

You can validate these APIs yourself by using the make validate target.

@lcawl lcawl requested a review from a team March 25, 2025 15:27
Copy link

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🥕

@lcawl lcawl force-pushed the backport/9.0/pr-4028 branch from fefad6f to cc69b2a Compare March 25, 2025 21:40
@lcawl lcawl merged commit 525893d into 9.0 Mar 25, 2025
7 checks passed
@lcawl lcawl deleted the backport/9.0/pr-4028 branch March 25, 2025 21:40
Copy link
Contributor

Following you can find the validation results for the APIs you have changed.

API Status Request Response
inference.put_googlevertexai Missing test Missing test

You can validate these APIs yourself by using the make validate target.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants