Add connector.secret private APIs #5727
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
pquentin
commented
Nov 24, 2025
Comment on lines
+21
to
+23
| body: { | ||
| deleted: boolean | ||
| } |
Member
Author
Comment on lines
+28
to
+39
| export interface Request extends RequestBase { | ||
| urls: [ | ||
| { | ||
| path: '/_connector/_secret/{id}' | ||
| methods: ['DELETE'] | ||
| } | ||
| ] | ||
| path_parts: { | ||
| /** The ID of the secret */ | ||
| id: string | ||
| } | ||
| } |
Member
Author
Comment on lines
+28
to
+39
| export interface Request extends RequestBase { | ||
| urls: [ | ||
| { | ||
| path: '/_connector/_secret/{id}' | ||
| methods: ['GET'] | ||
| } | ||
| ] | ||
| path_parts: { | ||
| /** The ID of the secret */ | ||
| id: string | ||
| } | ||
| } |
Member
Author
Comment on lines
+21
to
+24
| body: { | ||
| id: string | ||
| value: string | ||
| } |
Member
Author
Comment on lines
22
to
38
| /** | ||
| * Creates a secret for a Connector. | ||
| * | ||
| * @rest_spec_name connector.secret_post | ||
| * @availability stack stability=experimental visibility=private | ||
| */ | ||
| export interface Request extends RequestBase { | ||
| urls: [ | ||
| { | ||
| path: '/_connector/_secret' | ||
| methods: ['POST'] | ||
| } | ||
| ] | ||
| body: { | ||
| value: string | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
Comment on lines
+21
to
+23
| body: { | ||
| id: string | ||
| } |
Member
Author
Comment on lines
+29
to
+38
| urls: [ | ||
| { | ||
| path: '/_connector/_secret/{id}' | ||
| methods: ['PUT'] | ||
| } | ||
| ] | ||
| path_parts: { | ||
| /** The ID of the secret */ | ||
| id: string | ||
| } |
Member
Author
There was a problem hiding this comment.
Comment on lines
+23
to
+25
| body: { | ||
| result: Result | ||
| } |
Member
Author
Comment on lines
+29
to
+34
| urls: [ | ||
| { | ||
| path: '/_connector/_secret' | ||
| methods: ['POST'] | ||
| } | ||
| ] |
Member
Author
Comment on lines
+35
to
+37
| body: { | ||
| value?: string | ||
| } |
Member
Author
MattDevy
approved these changes
Nov 24, 2025
Contributor
MattDevy
left a comment
MattDevy
left a comment
There was a problem hiding this comment.
LGTM!
Thanks also for the comments to the elasticsearch repo for each Request / Response, it makes it really clear and easy to validate! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While those APIs are private, they are needed in Elasticsearch's rest-api-spec, which we want to generate from the specification.
Note that those APIs are surprisingly similar to the Fleet secret APIs that I've added in #5729.