char_filter pattern_replace error requires at least java 21 #116507
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Pinging @elastic/search-eng (Team:SearchOrg) |
|
Pinging @elastic/search-relevance (Team:Search - Relevance) |
mark-vieira
requested changes
Nov 8, 2024
modules/analysis-common/build.gradle
Outdated
| @@ -30,6 +28,12 @@ dependencies { | |||
| clusterModules project(':modules:mapper-extras') | |||
| } | |||
|
|
|||
| tasks.named("yamlRestTest").configure { task-> | |||
| if (BuildParams.getRuntimeJavaVersion().majorVersion.toInteger() < 21) { | |||
| task.skipTest("analysis-common/50_char_filters/pattern_replace error handling (too complex pattern)", "Requires Java 21 or later") | |||
There was a problem hiding this comment.
skipTest doesn't exist on this task. That method is only on compat task transform tasks so this will fail. You'll want to use the blacklist system property instead. Example:
elasticsearch/docs/build.gradle
Line 41 in 510a56b
There was a problem hiding this comment.
Also looking at the CI failure you'll need to an import for BuildParams in that build scripts.
import org.elasticsearch.gradle.internal.info.BuildParams
afoucret
approved these changes
Nov 8, 2024
mark-vieira
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test requires at least java 21, skip it otherwise.
closes: #116405
closes: #116134