Upgrade MinIO test container #128424
Merged
Upgrade MinIO test container #128424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Earlier versions of MinIO had a bug which can cause repository analysis failures. This commit upgrades the MinIO test container version to pick up the bug fix, and reverts the workaround implemented in elastic#127166. Relates minio/minio#21189
DaveCTurner
added
>test
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DaveCTurner
commented
May 25, 2025
Comment on lines
-45
to
-48
| // Skip listing of pre-existing uploads during a CAS because MinIO sometimes leaks them; also reduce the delay before proceeding | ||
| // TODO do not set these if running a MinIO version in which https://github.com/minio/minio/issues/21189 is fixed | ||
| .setting(REPOSITORY_S3_CAS_TTL_SETTING.getKey(), "-1") | ||
| .setting(REPOSITORY_S3_CAS_ANTI_CONTENTION_DELAY_SETTING.getKey(), "100ms") |
There was a problem hiding this comment.
Apparently I put the workaround in the wrong test suite 🤦
Comment on lines
-34
to
-37
| .setting("s3.client.repository_test_kit.protocol", () -> "http") | ||
| .setting("s3.client.repository_test_kit.endpoint", minioFixture::getAddress) | ||
| .setting("xpack.security.enabled", "false") | ||
| // Additional tracing related to investigation into https://github.com/elastic/elasticsearch/issues/102294 |
There was a problem hiding this comment.
Somewhat unrelated cleanup - the workaround should have been here.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 27, 2025
Earlier versions of MinIO had a bug which can cause repository analysis failures. This commit upgrades the MinIO test container version to pick up the bug fix, and reverts the workaround implemented in elastic#127166. Relates minio/minio#21189
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 27, 2025
Earlier versions of MinIO had a bug which can cause repository analysis failures. This commit upgrades the MinIO test container version to pick up the bug fix, and reverts the workaround implemented in #127166. Relates minio/minio#21189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier versions of MinIO had a bug which can cause repository analysis
failures. This commit upgrades the MinIO test container version to pick
up the bug fix, and reverts the workaround implemented in #127166.
Relates minio/minio#21189