ESQL: Added status to OrdinalsGroupingOperator #130720
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivancea
added
>non-issue
Team:Analytics
nik9000
reviewed
Jul 7, 2025
.../esql/compute/src/main/java/org/elasticsearch/compute/operator/OrdinalsGroupingOperator.java
Show resolved
Hide resolved
.../esql/compute/src/main/java/org/elasticsearch/compute/operator/OrdinalsGroupingOperator.java
Show resolved
Hide resolved
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
nik9000
approved these changes
Jul 11, 2025
nik9000
reviewed
Jul 11, 2025
| @@ -338,6 +338,7 @@ static TransportVersion def(int id) { | |||
| public static final TransportVersion ESQL_FIXED_INDEX_LIKE = def(9_119_0_00); | |||
| public static final TransportVersion LOOKUP_JOIN_CCS = def(9_120_0_00); | |||
| public static final TransportVersion NODE_USAGE_STATS_FOR_THREAD_POOLS_IN_CLUSTER_INFO = def(9_121_0_00); | |||
| public static final TransportVersion ESQL_ORDINALS_OPERATOR_STATUS = def(9_122_0_00); | |||
There was a problem hiding this comment.
If you are going to backport you should make the backport transport versions and use them in this PR before merging.
There was a problem hiding this comment.
You could do it in a follow-up PR, but this PR is small enough I'd do it in this one.
|
Hi @ivancea, I am working to remove this operator if the ordinal blocks perform comparably. Could you please hold off on merging this PR? Sorry for delaying/blocking your hard work. |
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
|
Operator removed on #131133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #130359