-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[ML] Block trained model updates from inference #130940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+395
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the Trained Model has been deployed through the Inference Endpoint API, it can only be updated using the Inference Endpoint API. When the Trained Model has been deployed and then attached to an Inference Endpoint, it can only be updated using the Trained Model API. Fix elastic#129999
Hi @prwhelan, I've created a changelog YAML for you. |
Pinging @elastic/ml-core (Team:ML) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, left a few questions.
...ce-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/CreateFromDeploymentIT.java
Show resolved
Hide resolved
.../main/java/org/elasticsearch/xpack/inference/action/TransportUpdateInferenceModelAction.java
Show resolved
Hide resolved
.../main/java/org/elasticsearch/xpack/inference/action/TransportUpdateInferenceModelAction.java
Show resolved
Hide resolved
...main/java/org/elasticsearch/xpack/ml/action/TransportUpdateTrainedModelDeploymentAction.java
Show resolved
Hide resolved
davidkyle
reviewed
Jul 14, 2025
...ce-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/CreateFromDeploymentIT.java
Outdated
Show resolved
Hide resolved
.../main/java/org/elasticsearch/xpack/inference/action/TransportUpdateInferenceModelAction.java
Show resolved
Hide resolved
...main/java/org/elasticsearch/xpack/ml/action/TransportUpdateTrainedModelDeploymentAction.java
Show resolved
Hide resolved
…tTest/java/org/elasticsearch/xpack/inference/CreateFromDeploymentIT.java Co-authored-by: David Kyle <[email protected]>
…inference/action/TransportUpdateInferenceModelAction.java Co-authored-by: David Kyle <[email protected]>
jonathan-buttner
approved these changes
Jul 14, 2025
davidkyle
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the Trained Model has been deployed through the Inference Endpoint API, it can only be updated using the Inference Endpoint API.
When the Trained Model has been deployed and then attached to an Inference Endpoint, it can only be updated using the Trained Model API.
Fix #129999