Update reference-docs-links.txt to include serverless doc reference link

[kunisen]

• Have you signed the contributor license agreement? Yes

• Have you followed the contributor guidelines? Yes

• If submitting code, have you built your formula locally prior to submission with gradle check?

There's no gradle check but I had to run ./gradlew check.
It didn't pass but I had a hard time understand what do those error means... 🙏 Could anyone please help me with how to move things forward please?
It doesn't seem like caused by my PR to be honest and that confused me...

> Task :libs:cli:test
WARNING: module-info.class ignored in patch: /Users/kuni/Work/00_src/elasticsearch/libs/entitlement/bridge/build/distributions/elasticsearch-entitlement-bridge-9.2.0-SNAPSHOT.jar

TerminalTests > classMethod FAILED
    java.lang.AssertionError: java.lang.IllegalStateException: unexpected trailing content at line 49
        at org.elasticsearch.common.ReferenceDocs.<clinit>(ReferenceDocs.java:111)
        at org.elasticsearch.cluster.metadata.IndexMetadata.<clinit>(IndexMetadata.java:132)
        at org.elasticsearch.index.IndexSettings.<clinit>(IndexSettings.java:349)
        at org.elasticsearch.index.mapper.Mapper.lambda$static$0(Mapper.java:86)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:216)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:291)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:344)
        at org.elasticsearch.common.settings.Setting.enumSetting(Setting.java:1742)
        at org.elasticsearch.index.mapper.Mapper.<clinit>(Mapper.java:83)
        at org.elasticsearch.indices.IndicesModule.initBuiltInMetadataMappers(IndicesModule.java:255)
        at org.elasticsearch.indices.IndicesModule.<clinit>(IndicesModule.java:246)
        at org.elasticsearch.test.ESTestCase.<clinit>(ESTestCase.java:2071)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:534)
        at java.base/java.lang.Class.forName(Class.java:513)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$2.run(RandomizedRunner.java:631)

        Caused by:
        java.lang.IllegalStateException: unexpected trailing content at line 49
            at org.elasticsearch.common.ReferenceDocs.createLinkComponentEntries(ReferenceDocs.java:165)
            at org.elasticsearch.common.ReferenceDocs.readLinksBySymbol(ReferenceDocs.java:126)
            at org.elasticsearch.common.ReferenceDocs.<clinit>(ReferenceDocs.java:109)
            ... 15 more


Suite: Test class org.elasticsearch.cli.TerminalTests

Exception in thread "Thread-3" java.lang.NoClassDefFoundError: Could not initialize class org.elasticsearch.test.ESTestCase
        at java.base/java.lang.Thread.run(Thread.java:1583)
        Suppressed: java.lang.IllegalStateException: No context information for thread: Thread[id=36, name=Thread-3, state=RUNNABLE, group=TGRP-TerminalTests]. Is this thread running under a class com.carrotsearch.randomizedtesting.RandomizedRunner runner context? Add @RunWith(class com.carrotsearch.randomizedtesting.RandomizedRunner.class) to your test class. Make sure your code accesses random contexts within @BeforeClass and @AfterClass boundary (for example, static test class initializers are not permitted to access random contexts).
                at com.carrotsearch.randomizedtesting.RandomizedContext.context(RandomizedContext.java:249)
                at com.carrotsearch.randomizedtesting.RandomizedContext.current(RandomizedContext.java:134)
                at com.carrotsearch.randomizedtesting.RandomizedRunner.augmentStackTrace(RandomizedRunner.java:1898)
                at com.carrotsearch.randomizedtesting.RunnerThreadGroup.uncaughtException(RunnerThreadGroup.java:20)
                at java.base/java.lang.Thread.dispatchUncaughtException(Thread.java:2902)
Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.AssertionError: java.lang.IllegalStateException: unexpected trailing content at line 49 [in thread "SUITE-TerminalTests-seed#[1FAEF00971EC824A]"]
        at org.elasticsearch.common.ReferenceDocs.<clinit>(ReferenceDocs.java:111)
        at org.elasticsearch.cluster.metadata.IndexMetadata.<clinit>(IndexMetadata.java:132)
        at org.elasticsearch.index.IndexSettings.<clinit>(IndexSettings.java:349)
        at org.elasticsearch.index.mapper.Mapper.lambda$static$0(Mapper.java:86)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:216)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:291)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:344)
        at org.elasticsearch.common.settings.Setting.enumSetting(Setting.java:1742)
        at org.elasticsearch.index.mapper.Mapper.<clinit>(Mapper.java:83)
        at org.elasticsearch.indices.IndicesModule.initBuiltInMetadataMappers(IndicesModule.java:255)
        at org.elasticsearch.indices.IndicesModule.<clinit>(IndicesModule.java:246)
        at org.elasticsearch.test.ESTestCase.<clinit>(ESTestCase.java:2071)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:534)
        at java.base/java.lang.Class.forName(Class.java:513)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$2.run(RandomizedRunner.java:631)

> Task :libs:core:test
WARNING: module-info.class ignored in patch: /Users/kuni/Work/00_src/elasticsearch/libs/entitlement/bridge/build/distributions/elasticsearch-entitlement-bridge-9.2.0-SNAPSHOT.jar
WARNING: module-info.class ignored in patch: /Users/kuni/Work/00_src/elasticsearch/libs/entitlement/bridge/build/distributions/elasticsearch-entitlement-bridge-9.2.0-SNAPSHOT.jar
WARNING: module-info.class ignored in patch: /Users/kuni/Work/00_src/elasticsearch/libs/entitlement/bridge/build/distributions/elasticsearch-entitlement-bridge-9.2.0-SNAPSHOT.jar

Exception in thread "Thread-3" java.lang.NoClassDefFoundError: Could not initialize class org.elasticsearch.test.ESTestCase
        at java.base/java.lang.Thread.run(Thread.java:1583)
        Suppressed: java.lang.IllegalStateException: No context information for thread: Thread[id=36, name=Thread-3, state=RUNNABLE, group=TGRP-FileAccessTreeComparisonTests]. Is this thread running under a class com.carrotsearch.randomizedtesting.RandomizedRunner runner context? Add @RunWith(class com.carrotsearch.randomizedtesting.RandomizedRunner.class) to your test class. Make sure your code accesses random contexts within @BeforeClass and @AfterClass boundary (for example, static test class initializers are not permitted to access random contexts).
                at com.carrotsearch.randomizedtesting.RandomizedContext.context(RandomizedContext.java:249)
                at com.carrotsearch.randomizedtesting.RandomizedContext.current(RandomizedContext.java:134)
                at com.carrotsearch.randomizedtesting.RandomizedRunner.augmentStackTrace(RandomizedRunner.java:1898)
                at com.carrotsearch.randomizedtesting.RunnerThreadGroup.uncaughtException(RunnerThreadGroup.java:20)
                at java.base/java.lang.Thread.dispatchUncaughtException(Thread.java:2902)
Caused by: java.lang.ExceptionInInitializerError: Exception java.lang.AssertionError: java.lang.IllegalStateException: unexpected trailing content at line 49 [in thread "SUITE-FileAccessTreeComparisonTests-seed#[1FAEF00971EC824A]"]
        at org.elasticsearch.common.ReferenceDocs.<clinit>(ReferenceDocs.java:111)
        at org.elasticsearch.cluster.metadata.IndexMetadata.<clinit>(IndexMetadata.java:132)
        at org.elasticsearch.index.IndexSettings.<clinit>(IndexSettings.java:349)
        at org.elasticsearch.index.mapper.Mapper.lambda$static$0(Mapper.java:86)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:216)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:291)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:344)
        at org.elasticsearch.common.settings.Setting.enumSetting(Setting.java:1742)
        at org.elasticsearch.index.mapper.Mapper.<clinit>(Mapper.java:83)
        at org.elasticsearch.indices.IndicesModule.initBuiltInMetadataMappers(IndicesModule.java:255)
        at org.elasticsearch.indices.IndicesModule.<clinit>(IndicesModule.java:246)
        at org.elasticsearch.test.ESTestCase.<clinit>(ESTestCase.java:2071)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:534)
        at java.base/java.lang.Class.forName(Class.java:513)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$2.run(RandomizedRunner.java:631)

> Task :libs:entitlement:test
WARNING: module-info.class ignored in patch: /Users/kuni/Work/00_src/elasticsearch/libs/entitlement/bridge/build/distributions/elasticsearch-entitlement-bridge-9.2.0-SNAPSHOT.jar
WARNING: module-info.class ignored in patch: /Users/kuni/Work/00_src/elasticsearch/libs/entitlement/bridge/build/distributions/elasticsearch-entitlement-bridge-9.2.0-SNAPSHOT.jar
WARNING: module-info.class ignored in patch: /Users/kuni/Work/00_src/elasticsearch/libs/entitlement/bridge/build/distributions/elasticsearch-entitlement-bridge-9.2.0-SNAPSHOT.jar

FileAccessTreeComparisonTests > classMethod FAILED
    java.lang.AssertionError: java.lang.IllegalStateException: unexpected trailing content at line 49
        at org.elasticsearch.common.ReferenceDocs.<clinit>(ReferenceDocs.java:111)
        at org.elasticsearch.cluster.metadata.IndexMetadata.<clinit>(IndexMetadata.java:132)
        at org.elasticsearch.index.IndexSettings.<clinit>(IndexSettings.java:349)
        at org.elasticsearch.index.mapper.Mapper.lambda$static$0(Mapper.java:86)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:216)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:291)
        at org.elasticsearch.common.settings.Setting.<init>(Setting.java:344)
        at org.elasticsearch.common.settings.Setting.enumSetting(Setting.java:1742)
        at org.elasticsearch.index.mapper.Mapper.<clinit>(Mapper.java:83)
        at org.elasticsearch.indices.IndicesModule.initBuiltInMetadataMappers(IndicesModule.java:255)
        at org.elasticsearch.indices.IndicesModule.<clinit>(IndicesModule.java:246)
        at org.elasticsearch.test.ESTestCase.<clinit>(ESTestCase.java:2071)
        at java.base/java.lang.Class.forName0(Native Method)
        at java.base/java.lang.Class.forName(Class.java:534)
        at java.base/java.lang.Class.forName(Class.java:513)
        at com.carrotsearch.randomizedtesting.RandomizedRunner$2.run(RandomizedRunner.java:631)

        Caused by:
        java.lang.IllegalStateException: unexpected trailing content at line 49
            at org.elasticsearch.common.ReferenceDocs.createLinkComponentEntries(ReferenceDocs.java:165)
            at org.elasticsearch.common.ReferenceDocs.readLinksBySymbol(ReferenceDocs.java:126)
            at org.elasticsearch.common.ReferenceDocs.<clinit>(ReferenceDocs.java:109)
            ... 15 more

...

• If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  Yes

• If submitting code, have you checked that your submission is for an OS and architecture that we support?
  It's not OS dependent. It's a doc PR-ish PR.

• If you are submitting this code for a class then read our policy for that.
  No.

[elasticsearchmachine]

@kunisen please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

[elasticsearchmachine]

Pinging @elastic/es-core-infra (Team:Core/Infra)

[elasticsearchmachine]

Pinging @elastic/es-docs (Team:Docs)

[kunisen]

hmm, it's giving so many errors... I was just adding a new line without any other change...

java.lang.AssertionError: java.lang.IllegalStateException: unexpected trailing content at line 49 > java.lang.IllegalStateException: unexpected trailing content at line 49 |  

[ldematte]

Hello @kunisen I don't think I get your intention here. That txt file contains relative URLs to docs that need to be referenced from ES error messages, and need to be defined in ReferenceDocs and accessed in the codebase from an appropriate way. What are you trying to achieve?

[kunisen]

Thanks @ldematte for your prompt response.
I was suggested by @rjernst to raise this PR first and then use it in another one as reference in stateless PR - https://github.com/elastic/elasticsearch-serverless/pull/4155#issuecomment-3048856996

[kunisen]

That txt file contains relative URLs to docs that need to be referenced from ES error messages, and need to be defined in ReferenceDocs and accessed in the codebase from an appropriate way

Could you kindly guide me how to do this in an appropriate way please? 🙏

[ldematte]

I see.
It should be as simple as adding DEPLOY_CLOUD_DIFF_FROM_STATEFUL at the end of the ReferenceDocs enum; that should do.
Be sure you don't add trailing spaces or characters to the txt file

[kunisen]

Thank you again @ldematte

It should be as simple as adding DEPLOY_CLOUD_DIFF_FROM_STATEFUL at the end of the ReferenceDocs enum; that should do.
Be sure you don't add trailing spaces or characters to the txt file

Could you kindly help me in advance to see what I did wrong please?

Actually I did the same in my first commit but it reported many errors and I made the 2nd update...
bdaffb3

[ldematte]

You need to also add DEPLOY_CLOUD_DIFF_FROM_STATEFUL at the end of the ReferenceDocs enum, in https://github.com/elastic/elasticsearch/blob/main/server/src/main/java/org/elasticsearch/common/ReferenceDocs.java#L87

[kunisen]

Thanks! Added.

[kunisen]

Got some timeout errors locally... But I guess they are unrelated anyways?

[rjernst]

LGTM