Skip to content

[9.1] [Test] Ensure assertion run only once (#131174) #131256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2025
Merged

[9.1] [Test] Ensure assertion run only once (#131174) #131256

merged 1 commit into from
Jul 15, 2025

Conversation

ywangd
Copy link
Member

@ywangd ywangd commented Jul 15, 2025

Backports the following commits to 9.1:

@ywangd
[Test] Ensure assertion run only once (elastic#131174)
2c8d8c3 
The assertion runs inside the cluster state listener may run a second
time if the listener is not removed in time. It is possible that the
assertion no longer holds on the 2nd time due to cluster state changes.
There is no need to assert it more than once. This PR ensures assertion
runs only once by removing the listener right after it.

Resolves: elastic#130274
@ywangd ywangd added :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Distributed Indexing Meta label for Distributed Indexing team labels Jul 15, 2025
@elasticsearchmachine elasticsearchmachine mentioned this pull request Jul 15, 2025
Merged
@elasticsearchmachine elasticsearchmachine merged commit 2c35e5c into elastic:9.1 Jul 15, 2025
34 checks passed
@ywangd ywangd deleted the backport/9.1/pr-131174 branch July 15, 2025 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :Distributed Indexing/CCR Issues around the Cross Cluster State Replication features Team:Distributed Indexing Meta label for Distributed Indexing team >test Issues or PRs that are addressing/adding tests v9.1.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ywangd @elasticsearchmachine