Add includeDiskInfo to toString()
#131358
Merged
+63
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `includeDiskInfo` parameter to the `cluster/allocation/explain` `toString()` method, and adds tests.
joshua-adams-1
added
>non-issue
:Distributed Coordination/Network
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
DiannaHohensee
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
LGTM 👍
You can add a Relates #127028 to the commit message for this. If you had used Closes #127028 for the main commit, it would have auto-closed the issue you're solving -- our docs show using that issue reference format, but don't explain what it does. The issue reference is nice, the rest is fanciness/laziness :)
| + "include_yes_decisions?=true,include_disk_info?=false"; | ||
| String actual = clusterAllocationExplainRequest.toString(); | ||
|
|
||
| assertTrue(actual.startsWith(expected)); |
There was a problem hiding this comment.
Should this be an assertEquals? It looks like you've spelled out the entire string, not just the beginning?
There was a problem hiding this comment.
Fixed in c4a6439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the
includeDiskInfoparameter to thecluster/allocation/explaintoString()method, and adds tests.Relates #127028