Skip to content

Add exception for perform embedding inference requests with query provided #131641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dan-rubinstein
Copy link
Member

@dan-rubinstein dan-rubinstein commented Jul 21, 2025

Issue - #131011

This change adds a check that throws an exception if an embedding (text or sparse embedding) perform inference request includes a query.

Testing:

  • Unit tests
  • Created a text embedding endpoint, called inference with query and made sure it failed. Called inference without query and made sure it succeeded.
  • Created a sparse embedding endpoint, called inference with query and made sure it failed. Called inference without query and made sure it succeeded.

@dan-rubinstein dan-rubinstein added >bug :ml Machine learning Team:ML Meta label for the ML team v9.2.0 labels Jul 21, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @dan-rubinstein, I've created a changelog YAML for you.

Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
59cc274

Please, read and sign the above mentioned agreement if you want to contribute to this project

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :ml Machine learning Team:ML Meta label for the ML team v9.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants