Introduce index.mapping.use_binary_doc_values to experiment with uncompressed binary doc values for keyword field. #136453
+621
−53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nary doc values for keyword field.
martijnvg
commented
Oct 13, 2025
Comment on lines
+262
to
+281
| if (isDense(firstDocId, doc, count)) { | ||
| try (var builder = factory.singletonBytesRefs(count)) { | ||
| long[] offsets = new long[count + 1]; | ||
|
|
||
| // Normalize the offsets to check of bytes that is going to be fetched: | ||
| int j = 1; | ||
| long startOffset = addresses.get(firstDocId); | ||
| for (int i = offset; i < docs.count(); i++) { | ||
| int docId = docs.get(i); | ||
| long nextOffset = addresses.get(docId + 1) - startOffset; | ||
| offsets[j++] = nextOffset; | ||
| } | ||
|
|
||
| int lastDocId = docs.get(docs.count() - 1); | ||
| int length = Math.toIntExact(addresses.get(lastDocId + 1L) - startOffset); | ||
| byte[] bytes = new byte[length]; | ||
| bytesSlice.readBytes(startOffset, bytes, 0, length); | ||
| builder.appendBytesRefs(bytes, offsets); | ||
| return builder.build(); | ||
| } |
There was a problem hiding this comment.
This is almost 2x faster than the else branch. Tested on my local machine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.