[ML] Remove legacy Anomaly detection v5.4 logic #136476
Open
+3
−102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The anomaly detection data count documents had a different naming format in Elasticsearch 5.4. The legacy code to search for both the old and new names are still in the codebase.
The effect of this change to remove the 5.4 doc id query term is that if an anomaly detection job was created and closed in 5.4 (circa 2017) and never opened since the data counts will not be found. If the job has been opened since 5.4 then a new data counts document will have been written with the modern naming format. Version 5.4 is stretching our commitment to backwards compatibility somewhat.