Fix EXTENDED_DOC_VALUES_PARAMS test cluster feature flag. #140519
+3
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit 8e3d3c9.
And use it in x-pack yaml integration test.
martijnvg
added
>test
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
parkertimmins
approved these changes
Jan 12, 2026
craigtaverner
approved these changes
Jan 12, 2026
Contributor
craigtaverner
left a comment
craigtaverner
left a comment
There was a problem hiding this comment.
If this works, it is great. I think we should add test-release to this PR to be sure of it.
| path: /_query | ||
| parameters: [ ] | ||
| capabilities: [ extended_doc_values_params ] | ||
| cluster_features: ["mapper.keyword.high_cardinality_length_function_fuse_to_load"] |
Contributor
There was a problem hiding this comment.
Does this work? How does it connect to extended_doc_values_options_feature_flag_enabled?
Contributor
There was a problem hiding this comment.
Ah, I spoke too soon. The line in XPackRestIT turns on this feature for all tests, so we no longer need to have a condition here related to the extended doc values params.
Member
Author
There was a problem hiding this comment.
It doesn't, the feature flag is now always set for test clusters in release builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And use it in x-pack yaml integration test.