Skip to content

Conversation

@acstll
Copy link
Contributor

@acstll acstll commented Dec 19, 2025

Summary

This PR enables adding data attributes to the dismiss button in EuiCallOut.

It introduces the dismissButtonProps prop, following a common pattern in the library.

Note

This PR also introduces a DataAttributeProps interface to ensure TypeScript is happy about data-* attributes — it's deliberate to have it separate from the already existing CommonProps —— it's also deliberate to use it only in dismissButtonProps for now

Why are we making this change?

To fulfill a request.

Impact to users

🟢 No impact. It's a new prop.

QA

  • Verify the new prop works as expected

General checklist

  • Browser QA
    • Checked in both light and dark modes
    • Checked in both MacOS and Windows high contrast modes
    • Checked in mobile
    • Checked in Chrome, Safari, Edge, and Firefox
    • Checked for accessibility including keyboard-only and screenreader modes
  • Docs site QA
  • Code quality checklist
  • Release checklist
    • A changelog entry exists and is marked appropriately
    • If applicable, added the breaking change issue label (and filled out the breaking change checklist)
    • If the changes unblock an issue in a different repo, smoke tested carefully (see Testing EUI features in Kibana ahead of time)
  • Designer checklist
    • If applicable, file an issue to update EUI's Figma library with any corresponding UI changes. (This is an internal repo, if you are external to Elastic, ask a maintainer to submit this request)

@acstll acstll self-assigned this Dec 19, 2025
@acstll acstll added skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) support-duty-flywheel Label for PRs, see eui-private #310 labels Dec 19, 2025
@acstll acstll changed the title [DRAFT][EuiCallOut] Add dismissButtonProps [EuiCallOut] Add dismissButtonProps Dec 23, 2025
@acstll acstll force-pushed the callout-dismiss-props branch from 556aabc to c8f7296 Compare January 13, 2026 11:34
@acstll acstll removed the skip-changelog Use on PRs to skip changelog requirement (Don't delete - used for automation) label Jan 13, 2026
@acstll acstll marked this pull request as ready for review January 13, 2026 12:06
@acstll acstll requested a review from a team as a code owner January 13, 2026 12:06
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @acstll

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @acstll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

support-duty-flywheel Label for PRs, see eui-private #310

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants