[EuiCallOut] Add dismissButtonProps
#9285
Open
+56
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enables adding data attributes to the dismiss button in
EuiCallOut.It introduces the
dismissButtonPropsprop, following a common pattern in the library.Note
This PR also introduces a
DataAttributePropsinterface to ensure TypeScript is happy about data-* attributes — it's deliberate to have it separate from the already existingCommonProps—— it's also deliberate to use it only indismissButtonPropsfor nowWhy are we making this change?
To fulfill a request.
Impact to users
🟢 No impact. It's a new prop.
QA
General checklist
@defaultif default values are missing) and playground toggles