[Release] 8.9.0 changelog

[juliaElastic]

What is the problem this PR solves?

8.9.0 changelog

How does this PR solve the problem?

// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

• I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
• I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
• I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in ./changelog/fragments using the changelog tool

Related issues

[juliaElastic]

replaced newlines with \n as the changelog tool complained, is there a way to check the rendered version?

[kilfoyle]

@juliaElastic The output here looks to be yaml format rather than asciidoc. It may not matter though, since I just copy the contents into a separate docs PR. Here's what I have for this breaking change:

Asciidoc:

[discrete]
[[breaking-2531]]
.API default error code is now 500
[%collapsible]
====
*Details* +
Previously, when {fleet-server} encountered an unexpected error it resulted in a `Bad Request` response.

*Impact* +
Now, any unexpected error returns an `Internal Server Error` response while keeping most of the current behavior
unchanged. On expected failure paths (for example, Agent Inactive, Missing Agent ID, Missing Auth Header) a `Bad Request` response is returned. For more information, refer to {fleet-server-pull}2531[#2531].
====

Rendering:

[juliaElastic]

The build failed with this message. Hey @kroustou could you help fixing this?

2023-07-20 15:12:54 ERROR  Unrecoverable error, skipping retries
--
  | 2023-07-20 15:12:54 FATAL  Failed to upload and process pipeline: Pipeline upload rejected: Pipeline "serverless-gitops-update-stack-image-tag" does not exist
  | 🚨 Error: The command exited with status 1

[kroustou]

This step should have been removed, I am on PTO, I can point to the PR that removes it next week

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-07-24T07:22:49.681+0000

• Duration: 45 min 35 sec

Test stats 🧪

Test	Results
Failed	0
Passed	742
Skipped	1
Total	743

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

[kroustou]

Hello again #2771 should have removed this step

[juliaElastic]

Hello again #2771 should have removed this step

Thanks! We should backport it to 8.9 branch.

[criamico]

I left a small comment but overall LGTM

[criamico]

LGTM

[juliaElastic]

/test

[juliaElastic]

@kroustou The build step fleet-server/pr-merge Expected — Waiting for status to be reported doesn't seem to start, do you know how to trigger it?

[kroustou]

@kroustou The build step fleet-server/pr-merge Expected — Waiting for status to be reported doesn't seem to start, do you know how to trigger it?

No idea, maybe you need some help from the @elastic/ci-systems team?

[kilfoyle]

LGTM for the changelog text! 👍

[juliaElastic]

Created a jira ticket for ci-systems: https://elasticco.atlassian.net/browse/ENGPRD-217
Could this be caused by the buildkite changes?

[jlind23]

@juliaElastic You can close the ticket, this is due to the fleet server migration to buildkite. Jenkins resources has been removed but the check is still mandatory on the 8.9 branch as it was only removed on main.