Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #3981) CP-7782 - Replace E2E pipeline execution with serverless-quality-gate… #3984

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 7, 2024

As announced in the PSA: Serverless E2E tests to synthetics we will be replacing the calls to the buildkite pipelines that run the E2E tests against an ENV with a serverless-quality-gates CHECK_SYNTHETICS.

Important:
Please review this PR carefully as here I am mostly just replacing the execution of the E2E with the default config values (and default tag) from the serverless-quality-gates CHECK_SYNTHETICS.

From the PSA:

We will no longer execute E2E tests as a quality gate. Instead, the quality gates should be checking for the statuses of some of the synthetics journeys which are constantly running in the overview cluster of each environment.
In fact, the services that rely on a workflow template in the gitops repo to execute E2E as a quality gate were migrated a while ago to the quality gate that checks for the status of synthetics journeys.

The quality gate in question is CHECK_SYNTHETICS which is part of elastic/serverless-quality-gates and it can be configured with the env variables:

  • CHECK_SYNTHETICS: true (to enable this quality gate)
  • CHECK_SYNTHETICS_TAG: the tag of the synthetics monitors to match to evaluate their statuses.

Example of the synthetics check quality gate configured for the project-api on QA.
The quality gate ensures that it only takes into account results of journeys that were executed after the deployment of the latest version of the service. By default it also waits for at least 2 successful results of each matched journey but this can be configured.

Notice that this quality gate will take longer than the execution of the E2E tests because it waits for 2 successful results of the matched journeys. Most of our current journeys run at 15 min intervals, which means that it can take about 30 min to succeed.


This is an automatic backport of pull request #3981 done by Mergify.

@mergify mergify bot requested a review from a team as a code owner October 7, 2024 17:49
@mergify mergify bot added the backport label Oct 7, 2024
@mergify mergify bot assigned mduarte Oct 7, 2024
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@jlind23 jlind23 merged commit 57d0dd2 into 8.x Oct 8, 2024
8 checks passed
@jlind23 jlind23 deleted the mergify/bp/8.x/pr-3981 branch October 8, 2024 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants