Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #4037) Support sampling rate in APM configuration #4052

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 28, 2024

What is the problem this PR solves?

This PR introduces support for APM sample rate using the values provided by elastic-agent though the control protocol
// Please do not just reference an issue. Explain WHAT the problem this PR solves here.

How does this PR solve the problem?

Added a check for a value of transacton sampling in apmConfigToInstrumentation (it's an optional float32) and formatted the vale as a string to be included in the instrumentation copnfig.
// Explain HOW you solved the problem in your code. It is possible that during PR reviews this changes and then this section should be updated.

How to test this PR locally

Design Checklist

  • I have ensured my design is stateless and will work when multiple fleet-server instances are behind a load balancer.
  • I have or intend to scale test my changes, ensuring it will work reliably with 100K+ agents connected.
  • I have included fail safe mechanisms to limit the load on fleet-server: rate limiting, circuit breakers, caching, load shedding, etc.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Related issues


This is an automatic backport of pull request #4037 done by [Mergify](https://mergify.com).

* Support sampling rate in APM configuration

(cherry picked from commit dbdd056)
@mergify mergify bot requested a review from a team as a code owner October 28, 2024 12:33
@mergify mergify bot added the backport label Oct 28, 2024
@mergify mergify bot requested review from kaanyalti and pchila October 28, 2024 12:33
@mergify mergify bot assigned pchila Oct 28, 2024
@pchila pchila merged commit a3d14ee into 8.x Oct 30, 2024
8 checks passed
@pchila pchila deleted the mergify/bp/8.x/pr-4037 branch October 30, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant