Add per event pipeline #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
reviewed
Jan 23, 2025
| @@ -165,3 +165,36 @@ func TestDynamicTemplates(t *testing.T) { | |||
| require.NoError(t, err) | |||
| require.Equal(t, int64(2), stat.Indexed) | |||
| } | |||
|
|
|||
| func TestPipeline(t *testing.T) { | |||
| client := docappendertest.NewMockElasticsearchClient(t, func(w http.ResponseWriter, r *http.Request) { | |||
There was a problem hiding this comment.
would be good to assert that pipeline is successfully passed in the request
There was a problem hiding this comment.
Updated the test so it checks that the pipelines made it.
mauri870
approved these changes
Jan 24, 2025
leehinman
force-pushed
the
add_pipeline_per_event
branch
from
bc7a950 to
182d33a
Compare
carsonip
approved these changes
Jan 28, 2025
|
@carsonip Looks like reviews and CI checks are green. I don't have write access to the repo so I can't merge, can you? |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds pipeline to the BulkIndexItem. This will be necessary to implement open-telemetry/opentelemetry-collector-contrib#37419